Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mount go mod cache #712

Merged
merged 2 commits into from
Apr 18, 2019
Merged

Mount go mod cache #712

merged 2 commits into from
Apr 18, 2019

Conversation

markmandel
Copy link
Member

To speed up things when the mod cache is required.

@markmandel
Mount go mod cache
17afad6 
To speed up things when the mod cache is required.
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. labels Apr 16, 2019
@markmandel markmandel added this to the 0.10.0 milestone Apr 16, 2019
@markmandel
Copy link
Member Author

@heartrobotninja do you see any issues with this?

@heartrobotninja
Copy link
Contributor

We should keep an eye on future Go releases which may change the functionality of the cache. LGTM.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c1520af1-49da-414e-8938-c9c2c7eb7c38

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/712/head:pr_712 && git checkout pr_712
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-17afad6

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 3792a241-2e6b-493e-b6a7-6341396e4c28

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a15858b8-25df-4595-9f62-758d48682f8a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/712/head:pr_712 && git checkout pr_712
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-c191a95

@markmandel markmandel merged commit 4dfa1ff into googleforgames:master Apr 18, 2019
@markmandel markmandel deleted the cleanup/mount-mod-cache branch April 18, 2019 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkowalski jkowalski jkowalski approved these changes

Assignees
No one assigned
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@markmandel @heartrobotninja @agones-bot @jkowalski